Snort Forums Archive

Archive Home » Snort Development » Oracle OCI Handlers missing from void Disconnect() spo_database.c

Please note that the categories listed below represent an archived version of our forums pages. To view the current version and be able to post and reply to threads, please register and login here to go to the full forums pages.

[ Notice: Full Version of This Topic ]

Oracle OCI Handlers missing from void Disconnect() spo_database.c

Posted by shadowbq on August 15, 2005 17:15:17

File: spo_database.c
Where is the CLEAN DISCONNECT from Oracle?

THIS IS ALL VERY RUFF.. verify all..

The Oracle OCI Handlers appear to be missing in the disconnect function:
(CLIP)
/*******************************************************************************
* Function: Disconnect(DatabaseData * data)
*
* Purpose: Database independent function to close a connection
*
******************************************************************************/
void Disconnect(DatabaseData * data)
(...... skip...)
#ifdef ENABLE_ODBC
if(data->shared->dbtype_id == DB_ODBC)
{
if(data->u_handle)
{
SQLDisconnect(data->u_connection);
SQLFreeHandle(SQL_HANDLE_ENV, data->u_handle);
}
}
#endif
(CLIP)

void SpoDatabaseCleanExitFunction(int signal, void *arg)

#Provides functionality calls for releasing of database connections and freeing
#of resources..

Disconnect(data);
if(data != NULL)
{
free(data);
data = NULL;
}
Why doesnt Disconnect() contain SOMETHING RUFF LIKE THIS??:

#ifdef ENABLE_ORACLE
if(data->shared->dbtype_id == DB_ORACLE)
{
if(data->u_handle)
{
OCILogoff(&data->o_servicecontext, data->o_error); / * Disconnect */
OCIHandleFree((dvoid **)&data->o_statement, OCI_HTYPE_STMT); /* Free handles */
OCIHandleFree((dvoid **)&data->o_error, OCI_HTYPE_ERROR); /* Free handles */

}
}
#endif

Posted by Joel_Esler on August 26, 2005 15:38:17

We are more than willing to put your patch into the spo_database.c code. Please submit a diff to us.
Thank you

Joel Esler
SOURCEfire